Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve loader type safety #3112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ibgreen
Copy link
Collaborator

@ibgreen ibgreen commented Oct 2, 2024

  • Move global loader options to core sub-object
  • This lets us enforce that options can only take sub-objects and provide more exact typing
  • A breaking change, motivated by interacting with a number of developers who get the options wrong and end up losing an hour before they get it right.
  • While technically breaking, typescript will catch the errors so the upgrade should be fairly painless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant