Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add virt-what check for system on google cloud. #485

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

linl-rh
Copy link
Collaborator

@linl-rh linl-rh commented Nov 28, 2024

No description provided.

Copy link
Collaborator

@liangxiao1 liangxiao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linl-rh If it is a gcp metal system, should we check the output equal 'google_cloud'? Thanks

@linl-rh
Copy link
Collaborator Author

linl-rh commented Dec 2, 2024

@linl-rh If it is a gcp metal system, should we check the output equal 'google_cloud'? Thanks

Discussed offline, don't consider a gcp metal system currently.

@linl-rh linl-rh merged commit ad24119 into virt-s1:master Dec 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants