Modify test_boot_fipsenabled case to be compatible with image mode #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liangxiao1
reviewed
Nov 22, 2024
| utils_lib.run_cmd(self, cmd, msg='Remove {}'.format(arg)) | ||
| reboot_require = True | ||
|
|
||
| if 'ostree' in cmdline: |
There was a problem hiding this comment.
Thanks @yoguo, seems we can use one addon_args here. The difference is in the boot params operation in image mode and package mode. Others looks good to me.
There was a problem hiding this comment.
Yes, the boot=UUID=xxx parameter exists in /proc/cmdline by default and we should not remove it in image mode. In addition, if other params in addon_args can be supported in image mode, we can add them gradually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.