Fix avatar labels turning grey when display name changes

Calling `labelMesh.dispose()` with `disposeMaterialAndTextures` set to `true` removed the memoized label materials from the scene without updating the memo. This meant memo entries pointed to empty textures/materials.
vircadia · Oct 24, 2023 · 1162454 · 1162454
1 parent 55c963f
commit 1162454
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/modules/entity/entities/LabelEntity.ts b/src/modules/entity/entities/LabelEntity.ts
@@ -429,7 +429,7 @@ export class LabelEntity {
         if (!labelMesh || !(/^Label/iu).test(labelMesh.name)) {
             return;
         }
-        labelMesh.dispose(false, true);
+        labelMesh.dispose(false, false);
     }
 
     /**
@@ -441,6 +441,6 @@ export class LabelEntity {
             return;
         }
         const labelMeshes = object.getChildMeshes(false, (node) => (/^Label/iu).test(node.name));
-        labelMeshes.forEach((labelMesh) => labelMesh.dispose(false, true));
+        labelMeshes.forEach((labelMesh) => labelMesh.dispose(false, false));
     }
 }