Fix lots of build warnings #1665
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om a region of size 0 [-Wstringop-overread]'
daleglass
added
needs testing (QA)
digisomni
added
needs changes
and removed
needs testing (QA)
daleglass
added
needs CR (code review)
needs testing (QA)
digisomni
requested changes
Jun 24, 2022
Co-authored-by: Kalila <[email protected]>
ctrlaltdavid
requested changes
Jun 30, 2022
ctrlaltdavid
requested changes
Jul 7, 2022
|
Hello! Is this still an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this the interface build is almost clean.
This adds a warning whitelist system -- there's some stuff we just can't fix yet because we can't upgrade Qt or OpenSSL. This also adds a way to make the build fail on warning, and this is intended to be enabled by default very soon to improve code quality.