Code simplification #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bleak now has macOS support, so we don't need the separate Adafriut library for macOS.
This allows to run BLEAK interface in the same loop as hubs, which makes it simpler.
Since both the hub and BLEAK is running within the same asyncio loop, we can call BLEAK APIs directly within hub control flow.
Since both user-code and Bluetooth handling code runs in the same asyncio loop, we can communicate directly and not through the queue.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request simplifies the code by running everything in single asyncio loop. This is possible since recent bleak also supports macOS and Windows. This code depends on earlier PR #5 by @dlech .