Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring sequence axiomatization more in line with carbon to fix #629 #638

Closed
wants to merge 1 commit into from

Conversation

pieter-bos
Copy link
Contributor

  • Weakened triggers for singleton
  • Placed append empty left/right in one quantifier
  • Split index_over_append into left/right version, and used separate arithmetic functions
  • Phrase disequality with skolem function for differing index

…oject#629

- Weakened triggers for singleton
- Placed append empty left/right in one quantifier
- Split index_over_append into left/right version, and used separate arithmetic functions
- Phrase disequality with skolem function for differing index
@mschwerhoff
Copy link
Contributor

@marcoeilers Didn't you also recently port Carbon's axioms to Silicon?

@marcoeilers
Copy link
Contributor

Yes, here: https://github.com/viperproject/silicon/tree/meilers_seq_set_axioms
That branch uses exactly Carbon's sequence, seq, and multiset axioms, in the same way. It's on the to-discuss-list for the next Viper meeting whether that's what we want.

@pieter-bos
Copy link
Contributor Author

I'll close this under the assumption that it's still the plan to work on #642 at some point (though I understand it's difficult and/or not the highest priority). For what it's worth we still run into triggering problems with the default data structures occasionally, though not very often.

@pieter-bos pieter-bos closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants