Generics improvements #1135
Closed
Generics improvements #1135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aurel300
commented
Aug 18, 2022
Comment on lines
+322
to
+327
| pub fn local_mir_with_caller( | ||
| &self, | ||
| def_id: LocalDefId, | ||
| caller_def_id: LocalDefId, | ||
| substs: SubstsRef<'tcx>, | ||
| ) -> Rc<mir::Body<'tcx>> { |
There was a problem hiding this comment.
@JonasAlaif Will this change be easy to incorporate into your refactored Environment? For proper monomorphisation (and assoc. type normalisation) I need called DefId, type substitutions (as before), but also the caller DefId.
And should I wait for your PR to land or can I merge this first (assuming the tests pass)?
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2022
1135: Generics improvements r=Aurel300 a=Aurel300 - [x] Improved associated types resolution (thanks `@vl0w,` from #980). The hope is that this won't erase too many regions... - [x] Normalise associated types when monomorphising MIR bodies for pure functions. - [x] Cache encoded pure functions by `DefId` + (full) encoded signature, not just "type parameters". Co-authored-by: Aurel Bílý <[email protected]> Co-authored-by: Jonas <[email protected]>
|
Canceled. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 18, 2022
1135: Generics improvements r=Aurel300 a=Aurel300 - [x] Improved associated types resolution (thanks `@vl0w,` from #980). The hope is that this won't erase too many regions... - [x] Normalise associated types when monomorphising MIR bodies for pure functions. - [x] Cache encoded pure functions by `DefId` + (full) encoded signature, not just "type parameters". Co-authored-by: Aurel Bílý <[email protected]> Co-authored-by: Jonas <[email protected]>
|
Build failed: |
|
Superseded by #1147 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefId+ (full) encoded signature, not just "type parameters".