Add Dockerfile #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are these changes?
Adds Docker/Podman support to this project. Simply run
./pnpmto launch a temporary container and execute PNPM on the project.Why are these changes being made?
I used these changes to develop #5 and thought others might find it useful.
A unified development environment improves the first-time developer experience. Rather than needing a guide on installing prerequisite dependencies, developers can simply use the included container image and compose configuration to automatically generate a common development environment. This also improves error reproduction and troubleshooting.
GitHub runners have Docker pre-installed, so this change also lends itself to creating a robust continuous integration system. Developers can write confidently, knowing that their changes will run identically on their machine and the CI system.
Checklist
./pnpm installsucceeds../pnpm run cisucceeds../pnpm run lintsucceeds../pnpm run devsucceeds../pnpm run cleansucceeds../pnpm run build:jssucceeds../pnpm run build:typessucceeds../pnpm run buildsucceeds../pnpm run preparesucceeds../pnpm run prepublishOnlysucceeds../pnpm installsucceeds../pnpm run cisucceeds../pnpm run lintsucceeds../pnpm run devsucceeds../pnpm run cleansucceeds../pnpm run build:jssucceeds../pnpm run build:typessucceeds../pnpm run buildsucceeds../pnpm run preparesucceeds../pnpm run prepublishOnlysucceeds../pnpm installsucceeds../pnpm run cisucceeds../pnpm run lintsucceeds../pnpm run devsucceeds../pnpm run cleansucceeds../pnpm run build:jssucceeds../pnpm run build:typessucceeds../pnpm run buildsucceeds../pnpm run preparesucceeds../pnpm run prepublishOnlysucceeds../pnpm installsucceeds../pnpm run cisucceeds../pnpm run lintsucceeds../pnpm run devsucceeds../pnpm run cleansucceeds../pnpm run build:jssucceeds../pnpm run build:typessucceeds../pnpm run buildsucceeds../pnpm run preparesucceeds../pnpm run prepublishOnlysucceeds../pnpm installsucceeds../pnpm run cisucceeds../pnpm run lintsucceeds../pnpm run devsucceeds../pnpm run cleansucceeds../pnpm run build:jssucceeds../pnpm run build:typessucceeds../pnpm run buildsucceeds../pnpm run preparesucceeds../pnpm run prepublishOnlysucceeds.Additional notes:
gitis not included in the image causing Husky to not install and return a0exit code.