Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose less elegant but more specific comparison #8

Merged
merged 7 commits into from
Feb 17, 2021

Conversation

smoia
Copy link

@smoia smoia commented Feb 16, 2021

Closes none

Propose a less elegant, but more specific pattern comparison to find triggers based on names.

Proposed Changes

  • Split the regex search into a multi-line for loop
  • Compare the name of the channel to the trigger, not viceversa
  • Remove (filter) empty strings from the channel name split.

Change Type

  • bugfix (+0.0.1)
  • minor (+0.1.0)
  • major (+1.0.0)
  • refactoring (no version update)
  • test (no version update)
  • infrastructure (no version update)
  • documentation (no version update)
  • other

Checklist before review

  • I added everything I wanted to add to this PR.
  • [Code or tests only] I wrote/updated the necessary docstrings.
  • [Code or tests only] I ran and passed tests locally.
  • [Documentation only] I built the docs locally.
  • My contribution is harmonious with the rest of the code: I'm not introducing repetitions.
  • My code respects the adopted style, especially linting conventions.
  • The title of this PR is explanatory on its own, enough to be understood as part of a changelog.
  • I added or indicated the right labels.
  • I added information regarding the timeline of completion for this PR.
  • Please, comment on my PR while it's a draft and give me feedback on the development!

@vinferrer
Copy link
Owner

vinferrer commented Feb 16, 2021

Could you add an example names to the tests that certifies this is working ?

@vinferrer
Copy link
Owner

Could you test a name that wasn't working before?

@smoia
Copy link
Author

smoia commented Feb 17, 2021

'CO2' was problematic before, see here

@vinferrer
Copy link
Owner

Fair enough, Merging

@vinferrer vinferrer merged commit 2046244 into vinferrer:auto_chtrig Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants