Add support for ULID validation #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, can we please have some tests for the |
Added some integration tests, tests for the |
|
Looks great! Thanks for the PR! Do you mind creating another PR in the documentation repository? |
Thanks for merging, will do during the day! |
|
@RomainLanz Added PR to docs here: vinejs/vinejs.dev#22 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
ULID is a widely used format for identifiers with some advantages over the canonically recognised UUID formats (1-5). ULIDs are natively supported in multiple frameworks, e.g. Laravel.
This pull request introduces support for ULID validation in VineJS by means of simple regex matching.
ULID specs: https://github.com/ulid/spec
📝 Checklist
Haven't been able to open a simple issue, only the "bug template" seems to work. If you consider to include this change I can update the docs accordingly.