Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes for lints #1298

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

etiennebacher
Copy link
Contributor

@etiennebacher etiennebacher commented Dec 8, 2024

Just the occasional run of flint to check recent changes (both in flint and in marginaleffects).

Copy link

github-actions bot commented Dec 8, 2024

Benchmark results

💥 means that PR is more than 5% slower than main or CRAN
⚡ means that PR is more than 5% faster than main or CRAN

Click to see benchmark results
Expression PR time (median, seconds) % change with “main” % change with CRAN PR memory (MB) Mem. % change with “main” Mem. % change with CRAN
slopes(mod, vcov = FALSE, newdata = “mean”) 0.16542169 2.88% -1.48% 208.616032 0% -0.09%
slopes(mod, newdata = “mean”) 0.36832158 2.96% 1.23% 212.750560 0% -0.05%
slopes(mod, vcov = FALSE, variables = “X3”) 0.13546119 3.08% 0.36% 546.284240 0% -0.24%
slopes(mod, variables = “X3”) 0.59888423 4.12% 2.64% 1085.126016 0% -0.12%
slopes(mod, vcov = FALSE) 2.24647086 💥 6.8% 💥 6.38% 11143.225296 0% -0.27%
slopes(mod) 8.45949390 1.22% 1.28% 21756.201496 0% -0.14%
hypotheses(mod, hypothesis = “b3 - b1 = 0”) 0.05735583 -0.27% -3.85%
4.538328
0% 0.78%
hypotheses(mod, hypothesis = “b2^2 * exp(b1) = 0”) 0.05693474 -0.68% -1.96%
4.054256
0% 0%
hypotheses(mod, hypothesis = ~reference) 0.08859271 -0.33% ⚡ -11.55%
9.020664
0% 0%
predictions(mod) 0.49562093 -0.78% -2.32% 1493.568280 0% 0%
predictions(mod, newdata = “mean”) 0.14292761 -1.62% -2.71% 82.176264 0% 0%
predictions(mod, newdata = datagrid(X2 = unique)) 4.22239644 -3.88% ⚡ -5.14% 1654.511536 -0.01% -0.1%
comparisons(mod2) 0.66834452 1.02% 0.61% 1231.289752 0% -0.58%
comparisons(mod2, comparison = “dydxavg”) 0.49218137 -0.04% -0.45% 993.824936 0% -0.01%
comparisons(mod2, comparison = “eydxavg”) 1.36469555 1.11% 0.32% 1650.446848 0% 0%
comparisons(mod2, comparison = “ratioavg”) 0.50285362 -0.86% -0.65% 966.441040 0% -0.01%

Generated via commit 7835eb4

Download link for the artifact containing the test results: ↓ benchmark-results.zip

@vincentarelbundock vincentarelbundock merged commit 593696a into vincentarelbundock:main Dec 11, 2024
6 checks passed
@vincentarelbundock
Copy link
Owner

Thanks!

@etiennebacher etiennebacher deleted the flint branch December 11, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants