multcomp works with raw models

vincentarelbundock · Dec 11, 2024 · 8a2b01e · 8a2b01e
1 parent cca37b3
commit 8a2b01e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/R/hypotheses.R b/R/hypotheses.R
@@ -443,9 +443,6 @@ hypotheses <- function(
 
   out <- sort_columns(out)
 
-  out <- multcomp_test(out, multcomp = multcomp, conf_level = conf_level)
-
-
   class(out) <- c("hypotheses", "deltamethod", class(out))
   attr(out, "posterior_draws") <- draws
   attr(out, "model") <- model
@@ -456,6 +453,9 @@ hypotheses <- function(
   attr(out, "vcov.type") <- vcov.type
   attr(out, "conf_level") <- conf_level
 
+  # must be after attributes for vcov
+  out <- multcomp_test(out, multcomp = multcomp, conf_level = conf_level)
+
   # Issue #1102: hypotheses() should not be called twice on the same object
   attr(out, "hypotheses_call") <- TRUE
 

diff --git a/inst/tinytest/test-multcomp.R b/inst/tinytest/test-multcomp.R
@@ -19,4 +19,11 @@ mod <- lm(y ~ x * z)
 pre1 <- avg_predictions(mod, by = "z")
 pre2 <- hypotheses(pre1, multcomp = "single-step")
 expect_true(any(pre1$p.value < pre2$p.value))
-expect_true(all(pre1$p.value <= pre2$p.value))
+expect_true(all(pre1$p.value <= pre2$p.value))
+
+mod <- lm(y ~ x * z)
+pkgload::load_all()
+hyp1 <- hypotheses(mod)
+hyp2 <- hypotheses(mod, multcomp = "single-step")
+expect_true(any(hyp1$p.value < hyp2$p.value))
+expect_true(all(hyp1$p.value <= hyp2$p.value))