kwang yang flask hw #1
Conversation
| def get_profile(id): | ||
| try: | ||
| data = {'name': db[id]['name'], 'scores': db[id]['scores']} |
There was a problem hiding this comment.
consider just db[id] since the next question for POST is: POST /profiles to create a new profile (name only)
| id = int(id) | ||
| deleted = db[id] | ||
| new_db = [profile for profile in db if profile != deleted] |
There was a problem hiding this comment.
consider del db[id] since doing this does not "delete" them from db variable.
e.g. DELETE request to delete id 0. output tells me that id 0 has been removed and the new_db does not have id 0. then I proceed to DELETE request to delete id 1. output tells me that id 1 has been removed but the new_db still have that id 0 person who is not supposed to be there anymore.
| try: | ||
| username = request.args.get('username') | ||
| password_hash = request.args.get('passwordHash') |
There was a problem hiding this comment.
line 18 is password but this line is passwordHash. after registering the user (with username and password), when i do a login, the user doesnt have a passwordHash. consider changing line 18 to get('passwordHash'), or this line to get('password')
| try: | ||
| minScore = request.args.get('minScore') | ||
| if minScore is None: |
There was a problem hiding this comment.
consider also: if minScore == ''
for if minScore is None: the request in POSTMAN is something like this profiles/0/score
for if minScore == '' the request in POSTMAN is something like profiles/0/score?=minScore
No description provided.