Fix overwriting userRes headers when using userResHeaderDecorator #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #547
previously, the proxy response would overwrite same-named headers without the possibility to fix it in
userResHeaderDecorator
. This is problematic e.g. for applications that useset-cookie
for auth cookies set in a middleware before the proxy middleware, and where the proxy response overwrites this header.this change is backwards-compatible and keeps overwriting headers, but when using
userResHeaderDecorator
, the original headers can be read fromuserRes
and returned to the caller.