Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set the configurable options to the top #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rubo77
Copy link
Contributor

@rubo77 rubo77 commented May 21, 2017

And cleaned up some comments

: ${ffssid:=freiburg.freifunk.net} # if for whatever reason ffssid is NULL, obviously not generic

# nameservers
NS1=10.60.0.100
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cannot accept this , since this is
a) not generic (which not neccesarly mean it will be merged)
b) differ from freifunk freiburg setup

@rubo77
Copy link
Contributor Author

rubo77 commented May 27, 2017

Please adapt it as you need it for your setup

@rubo77
Copy link
Contributor Author

rubo77 commented May 27, 2017

What exactly is different from before?

I think I just moved everything to the top but didn't change anything


# nameservers
NS1=10.60.0.100
NS2=4.2.2.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above comment . and feeding google may also be not invented more than it is already

# nameservers
NS1=10.60.0.100
NS2=4.2.2.2
NS3=10.60.0.110
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i may look into it - but in general i had issues to make this package more generic - and i have to think deeper into it - i may read (and write if not there) some uci stuff, so ever community could change it by its own

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you try your version of the file?

@rubo77
Copy link
Contributor Author

rubo77 commented May 29, 2017

No it is untested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants