fix for golint errcheck

Signed-off-by: Andrews Arokiam <[email protected]>

.golangci.yml

@@ -26,5 +26,3 @@ linters:
     - unconvert
     - unparam
     - gofmt
-  disable:
-    - errcheck

cmd/agent/main.go

@@ -209,7 +209,9 @@ func main() {
 	case err := <-errCh:
 		logger.Errorw("Failed to bring up agent, shutting down.", zap.Error(err))
 		// This extra flush is needed because defers are not handled via os.Exit calls.
-		logger.Sync()
+		if err := logger.Sync(); err != nil {
+			logger.Errorw("Error syncing logger: %v", err)
+		}
 		os.Stdout.Sync()
 		os.Stderr.Sync()
 		os.Exit(1)

pkg/agent/downloader.go

@@ -65,7 +65,7 @@ func (d *Downloader) DownloadModel(modelName string, modelSpec *v1alpha1.ModelSp
 			if err != nil {
 				return errors.Wrapf(createErr, "failed to encode model spec")
 			}
-			err = os.WriteFile(successFile, encodedJson, 0644)
+			err = os.WriteFile(successFile, encodedJson, 0644) // nolint gosec
 			if err != nil {
 				return errors.Wrapf(createErr, "failed to write the success file")
 			}

pkg/agent/storage/https.go

@@ -163,7 +163,7 @@ func extractZipFiles(reader io.Reader, dest string) error {
 
 	// Read all the files from zip archive
 	for _, zipFile := range zipReader.File {
-		fileFullPath := filepath.Join(dest, zipFile.Name)
+		fileFullPath := filepath.Join(dest, zipFile.Name) // nolint gosec
 		if !strings.HasPrefix(fileFullPath, filepath.Clean(dest)+string(os.PathSeparator)) {
 			return fmt.Errorf("%s: illegal file path", fileFullPath)
 		}
@@ -186,7 +186,7 @@ func extractZipFiles(reader io.Reader, dest string) error {
 			return fmt.Errorf("unable to open file: %w", err)
 		}
 
-		_, err = io.Copy(file, rc)
+		_, err = io.Copy(file, rc) // nolint gosec
 		closeErr := file.Close()
 		if closeErr != nil {
 			return closeErr
@@ -225,7 +225,7 @@ func extractTarFiles(reader io.Reader, dest string) error {
 			return fmt.Errorf("unable to access next tar file: %w", err)
 		}
 
-		fileFullPath := filepath.Join(dest, header.Name)
+		fileFullPath := filepath.Join(dest, header.Name) // nolint gosec
 		if header.Typeflag == tar.TypeDir {
 			err = os.MkdirAll(fileFullPath, 0755)
 			if err != nil {
@@ -239,7 +239,7 @@ func extractTarFiles(reader io.Reader, dest string) error {
 		if err != nil {
 			return err
 		}
-		if _, err := io.Copy(newFile, tr); err != nil {
+		if _, err := io.Copy(newFile, tr); err != nil { // nolint gosec
 			return fmt.Errorf("unable to copy contents to %s: %w", header.Name, err)
 		}
 	}

pkg/apis/serving/v1beta1/inference_service_status.go

@@ -443,7 +443,9 @@ func (ss *InferenceServiceStatus) SetCondition(conditionType apis.ConditionType,
 
 func (ss *InferenceServiceStatus) ClearCondition(conditionType apis.ConditionType) {
 	if conditionSet.Manage(ss).GetCondition(conditionType) != nil {
-		conditionSet.Manage(ss).ClearCondition(conditionType)
+		if err := conditionSet.Manage(ss).ClearCondition(conditionType); err != nil {
+			return
+		}
 	}
 }
 

pkg/constants/constants.go

@@ -127,7 +127,7 @@ const (
 // StorageSpec Constants
 var (
 	DefaultStorageSpecSecret     = "storage-config"
-	DefaultStorageSpecSecretPath = "/mnt/storage-secret"
+	DefaultStorageSpecSecretPath = "/mnt/storage-secret" // nolint gosec
 )
 
 // Controller Constants

pkg/controller/v1alpha1/trainedmodel/controller.go

@@ -85,7 +85,10 @@ func (r *TrainedModelReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	if err := r.Get(context.TODO(), types.NamespacedName{Namespace: req.Namespace, Name: tm.Spec.InferenceService}, isvc); err != nil {
 		if errors.IsNotFound(err) {
 			log.Info("Parent InferenceService does not exists, deleting TrainedModel", "TrainedModel", tm.Name, "InferenceService", isvc.Name)
-			r.Delete(context.TODO(), tm)
+			if err := r.Delete(context.TODO(), tm); err != nil {
+				log.Error(err, "Error deleting resource")
+				return reconcile.Result{}, err
+			}
 			return reconcile.Result{}, nil
 		}
 		return reconcile.Result{}, err

pkg/controller/v1beta1/inferenceservice/controller.go

@@ -189,7 +189,10 @@ func (r *InferenceServiceReconciler) Reconcile(ctx context.Context, req ctrl.Req
 		if err != nil {
 			r.Log.Error(err, "Failed to reconcile", "reconciler", reflect.ValueOf(reconciler), "Name", isvc.Name)
 			r.Recorder.Eventf(isvc, v1.EventTypeWarning, "InternalError", err.Error())
-			r.updateStatus(isvc, deploymentMode)
+			if err := r.updateStatus(isvc, deploymentMode); err != nil {
+				r.Log.Error(err, "Error updating status")
+				return result, err
+			}
 			return reconcile.Result{}, errors.Wrapf(err, "fails to reconcile component")
 		}
 		if result.Requeue || result.RequeueAfter > 0 {
@@ -332,7 +335,7 @@ func (r *InferenceServiceReconciler) deleteExternalResources(isvc *v1beta1api.In
 	}
 
 	for _, v := range trainedModels.Items {
-		if err := r.Delete(context.TODO(), &v, client.PropagationPolicy(metav1.DeletePropagationBackground)); client.IgnoreNotFound(err) != nil {
+		if err := r.Delete(context.TODO(), &v, client.PropagationPolicy(metav1.DeletePropagationBackground)); client.IgnoreNotFound(err) != nil { // nolint gosec
 			r.Log.Error(err, "unable to delete trainedmodel", "trainedmodel", v)
 		}
 	}

pkg/controller/v1beta1/inferenceservice/reconcilers/hpa/hpa_reconciler.go

@@ -61,7 +61,7 @@ func getHPAMetrics(metadata metav1.ObjectMeta, componentExt *v1beta1.ComponentEx
 
 	if value, ok := annotations[constants.TargetUtilizationPercentage]; ok {
 		utilizationInt, _ := strconv.Atoi(value)
-		utilization = int32(utilizationInt)
+		utilization = int32(utilizationInt) // nolint gosec
 	} else {
 		utilization = constants.DefaultCPUUtilization
 	}

pkg/controller/v1beta1/inferenceservice/reconcilers/service/service_reconciler.go

@@ -103,7 +103,7 @@ func createService(componentMeta metav1.ObjectMeta, componentExt *v1beta1.Compon
 				Port: constants.CommonDefaultHttpPort,
 				TargetPort: intstr.IntOrString{
 					Type:   intstr.Int,
-					IntVal: int32(port),
+					IntVal: int32(port), // nolint gosec
 				},
 				Protocol: corev1.ProtocolTCP,
 			})

pkg/credentials/azure/azure_secret.go

@@ -32,7 +32,7 @@ const (
 	AzureSubscriptionId = "AZURE_SUBSCRIPTION_ID"
 	AzureTenantId       = "AZURE_TENANT_ID"
 	AzureClientId       = "AZURE_CLIENT_ID"
-	AzureClientSecret   = "AZURE_CLIENT_SECRET"
+	AzureClientSecret   = "AZURE_CLIENT_SECRET" // nolint gosec
 )
 
 var (

pkg/credentials/gcs/gcs_secret.go

@@ -17,14 +17,14 @@ limitations under the License.
 package gcs
 
 import (
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 )
 
 const (
-	GCSCredentialFileName        = "gcloud-application-credentials.json"
-	GCSCredentialVolumeName      = "user-gcp-sa"
-	GCSCredentialVolumeMountPath = "/var/secrets/"
-	GCSCredentialEnvKey          = "GOOGLE_APPLICATION_CREDENTIALS"
+	GCSCredentialFileName        = "gcloud-application-credentials.json" // nolint gosec
+	GCSCredentialVolumeName      = "user-gcp-sa"                         // nolint gosec
+	GCSCredentialVolumeMountPath = "/var/secrets/"                       // nolint gosec
+	GCSCredentialEnvKey          = "GOOGLE_APPLICATION_CREDENTIALS"      // nolint gosec
 )
 
 type GCSConfig struct {

pkg/credentials/s3/s3_secret.go

@@ -28,7 +28,7 @@ Boto: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuratio
 */
 const (
 	AWSAccessKeyId         = "AWS_ACCESS_KEY_ID"
-	AWSSecretAccessKey     = "AWS_SECRET_ACCESS_KEY"
+	AWSSecretAccessKey     = "AWS_SECRET_ACCESS_KEY" // nolint gosec
 	AWSAccessKeyIdName     = "awsAccessKeyID"
 	AWSSecretAccessKeyName = "awsSecretAccessKey"
 	AWSEndpointUrl         = "AWS_ENDPOINT_URL"

tools/tf2openapi/cmd/main.go

@@ -39,7 +39,10 @@ func main() {
 	}
 
 	rootCmd.Flags().StringVarP(&modelBasePath, "model_base_path", "m", "", "Absolute path of SavedModel file")
-	rootCmd.MarkFlagRequired("model_base_path")
+	if err := rootCmd.MarkFlagRequired("model_base_path"); err != nil {
+		log.Fatalln(err.Error())
+	}
+
 	rootCmd.Flags().StringVarP(&modelName, "name", "n", "model", "Name of model")
 	rootCmd.Flags().StringVarP(&modelVersion, "version", "v", "1", "Model version")
 	rootCmd.Flags().StringVarP(&outFile, "output_file", "o", "", "Absolute path of file to write OpenAPI spec to")