Skip to content

Commit

Permalink
Bump Guava to make reflections work with Java 11
Browse files Browse the repository at this point in the history
With Java 11 and Guava 14.0.x `com.google.common.reflectClassPath.from(ClassLoader.getSystemClassLoader()).getAllClasses()` returns an empty `Set`. From a consumers perspective it is not possible to upgrade Guava on that side since `rdi-client-java` depends on a version of Guava which has had a non-compatible API change.

Resolves: metamx#7
  • Loading branch information
Johan Rydström committed Oct 23, 2019
1 parent d4e40ee commit e897a4f
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion core/src/main/java/com/metamx/rdiclient/RdiClientImpl.java
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ private ListenableFuture<HttpResponseStatus> retryingPost(
)
{
final SettableFuture<HttpResponseStatus> retVal = SettableFuture.create();
final ListenableFuture<HttpResponseStatus> response = Futures.transform(
final ListenableFuture<HttpResponseStatus> response = Futures.transformAsync(
httpClient.go(request, new StatusResponseHandler(Charsets.UTF_8)),
new AsyncFunction<StatusResponseHolder, HttpResponseStatus>()
{
Expand Down
5 changes: 5 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@
<artifactId>validation-api</artifactId>
<version>1.0.0.GA</version>
</dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
<version>25.0-jre</version>
</dependency>

<!-- Jackson -->
<dependency>
Expand Down

0 comments on commit e897a4f

Please sign in to comment.