Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash scripts refactoring into Golang #750

Merged

Conversation

flyinghorse0510
Copy link
Contributor

@flyinghorse0510 flyinghorse0510 commented Jun 2, 2023

Refactoring Lists

  • scripts/cluster/*.sh (In-place)
  • scripts/install_*.sh (moved to scripts/setup/install.go)
  • scripts/setup_*.sh (moved to scripts/setup/setup.go)
  • scripts/configs/*.go (all scripts' configuration, including version, url, etc)
  • scripts/utils/*.go (self-written utilities, including logging and some system tools)
  • scripts/cloudlab/*.sh (In-place, not fully tested)
  • scripts/create_*.sh (moved to scripts/setup/create.go)
  • scripts/setup.go (CLI Wrapper for all sub-scripts)

Improving Lists

  • code format improvement(readability, indent, etc...)
  • CI workflow and fully test
  • documents and README

Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add the regular copyrights with your name and the vHive community
  • use logrus instead of the default log.
  • move config variables to a JSON file. that file should have a hierarchy of parameters (e.g., kubernetes, contained, etc) just like you structured files in scripts/configs.
  • move scripts/configs to configs/vHive

scripts/setup/install.go Outdated Show resolved Hide resolved
scripts/setup/install.go Outdated Show resolved Hide resolved
scripts/setup/install.go Outdated Show resolved Hide resolved
scripts/setup/setup.go Outdated Show resolved Hide resolved
scripts/setup/setup.go Outdated Show resolved Hide resolved
scripts/configs/configs.go Outdated Show resolved Hide resolved
scripts/cluster/setup_worker_kubelet.go Outdated Show resolved Hide resolved
scripts/cluster/create_multinode_cluster.go Outdated Show resolved Hide resolved
scripts/cluster/create_multinode_cluster.go Outdated Show resolved Hide resolved
scripts/cluster/create_one_node_cluster.go Show resolved Hide resolved
configs/setup/knative.json Outdated Show resolved Hide resolved
configs/setup/kube.json Outdated Show resolved Hide resolved
configs/setup/system.json Outdated Show resolved Hide resolved
configs/setup/system.json Outdated Show resolved Hide resolved
configs/setup/system.json Outdated Show resolved Hide resolved
configs/setup/system.json Outdated Show resolved Hide resolved
scripts/cloudlab/setup_node.go Outdated Show resolved Hide resolved
scripts/cloudlab/setup_node.go Show resolved Hide resolved
scripts/utils/system.go Outdated Show resolved Hide resolved
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please describe where to find which parameters throughout config JSON files. Make sure there are no parameters that replicate each other (e.g., those that can be derived based on the k8s version).

configs/setup/system.json Outdated Show resolved Hide resolved
@ustiugov
Copy link
Member

please increase verbosity in logging

image

@ustiugov ustiugov changed the title incomplete bash scripts refactoring Bash scripts refactoring into Golang Aug 17, 2023
@ustiugov ustiugov merged commit 7fd61cd into vhive-serverless:main Aug 19, 2023
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants