-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bash scripts refactoring into Golang #750
Merged
ustiugov
merged 7 commits into
vhive-serverless:main
from
flyinghorse0510:vhive-incomplete-scripts
Aug 19, 2023
Merged
Bash scripts refactoring into Golang #750
ustiugov
merged 7 commits into
vhive-serverless:main
from
flyinghorse0510:vhive-incomplete-scripts
Aug 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ustiugov
reviewed
Jun 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add the regular copyrights with
your name and the vHive community
- use logrus instead of the default log.
- move config variables to a JSON file. that file should have a hierarchy of parameters (e.g., kubernetes, contained, etc) just like you structured files in scripts/configs.
- move scripts/configs to configs/vHive
ustiugov
reviewed
Jun 12, 2023
ustiugov
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please describe where to find which parameters throughout config JSON files. Make sure there are no parameters that replicate each other (e.g., those that can be derived based on the k8s version).
ustiugov
changed the title
incomplete bash scripts refactoring
Bash scripts refactoring into Golang
Aug 17, 2023
ustiugov
force-pushed
the
vhive-incomplete-scripts
branch
from
August 17, 2023 10:07
ea6ea6e
to
670a18c
Compare
flyinghorse0510
force-pushed
the
vhive-incomplete-scripts
branch
from
August 17, 2023 15:40
6b0ed21
to
670a18c
Compare
Signed-off-by: flyinghorse0510 <[email protected]>
…c files Signed-off-by: flyinghorse0510 <[email protected]>
Signed-off-by: flyinghorse0510 <[email protected]>
Signed-off-by: flyinghorse0510 <[email protected]>
Signed-off-by: flyinghorse0510 <[email protected]>
Signed-off-by: flyinghorse0510 <[email protected]>
Signed-off-by: flyinghorse0510 <[email protected]>
flyinghorse0510
force-pushed
the
vhive-incomplete-scripts
branch
from
August 19, 2023 07:27
dd7340c
to
e946d9b
Compare
ustiugov
approved these changes
Aug 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Lists
Improving Lists