Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script to buid fc, fccd and knative #178

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

add script to buid fc, fccd and knative #178

wants to merge 1 commit into from

Conversation

shyamjesal
Copy link
Collaborator

Signed-off-by: Shyam Jesal [email protected]

@shyamjesal shyamjesal self-assigned this Mar 17, 2021
@shyamjesal shyamjesal linked an issue Mar 17, 2021 that may be closed by this pull request
Add a script that rebuilds the dependencies' binaries #96
Open
@ustiugov
Copy link
Member

let's not rush this all in a single PR.

Let me submit a PR with a new firecracker binary first, then let's have another one for the firecracker-containerd binaries, then push the latest knative containers to dockerhub. Then we can package it all in one build script.

Also, from my experience, the script should only build all the binaries and push them on success but do not try to rebase the branches automatically. This must still remain manual (due to complexity and conflicts).

@shyamjesal shyamjesal force-pushed the update-deps branch 2 times, most recently from 0b1257c to 58406c0 Compare March 18, 2021 10:11
@shyamjesal shyamjesal changed the title update fccd and firecracker binaries add script to buid fc, fccd and knative Mar 18, 2021
ustiugov
ustiugov requested changes Mar 18, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the scripts, there should be a variable for the branch name. All dependencies should have branches with the same name. It is likely that vHive updates will be mostly driven by changes in the firecracker repo so let's call the branches v<FC_version>_user_page_faults.

I guess that the knative part is incomplete as of now, isn't it?

scripts/github_runner/setup_runner_host.sh

sudo apt-get update
sudo apt-get install --yes docker-ce docker-ce-cli containerd.io >> /dev/null
jq >> /dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

28-29 should be one line

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pushed?

scripts/rebuild_deps.sh Outdated
# cp build/cargo_target/x86_64-unknown-linux-musl/release/jailer $PWD/../bin/

# install knative dependencies
sudo apt install -y git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you used git above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

scripts/rebuild_deps.sh Show resolved Hide resolved
scripts/rebuild_deps.sh Outdated
cd firecracker-containerd
make all

# copy binaries binaries to vhive/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# copy binaries binaries to vhive/bin
# copy binaries to vhive/bin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

scripts/rebuild_deps.sh Outdated
Comment on lines 38 to 42

cd _submodules/firecracker/
tools/devtool build --release

# copy binaries binaries to vhive/bin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cd _submodules/firecracker/
tools/devtool build --release
# copy binaries binaries to vhive/bin

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

scripts/rebuild_deps.sh Outdated
go get github.com/gogo/protobuf/protoc-gen-gogofaster

#build knative
git clone -b qp_guest_info https://github.com/ease-lab/serving
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the branch name a variable, also make sure that you don't change qp_quest_info

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

ustiugov
ustiugov requested changes Mar 22, 2021
View reviewed changes
Copy link
Member

@ustiugov ustiugov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add building Docker images of the runners as well (with pushing them to dockerhub).

DOCKER_BUILDKIT=1 docker build -t vhiveease/vhive_dev_env --file ./scripts/github_runner/Dockerfile.cri_dev_env . 
docker push vhiveease/vhive_dev_env
DOCKER_BUILDKIT=1 docker build -t vhiveease/cri_test_runner --file ./scripts/github_runner/Dockerfile.github_runner_cri .
docker push docker.io/vhiveease/cri_test_runner

scripts/rebuild_deps.sh
KNATIVE_BRANCH=$2

set -x
PWD="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please replace PWD with MYSCRIPT_DIR or so

scripts/github_runner/setup_runner_host.sh

sudo apt-get update
sudo apt-get install --yes docker-ce docker-ce-cli containerd.io >> /dev/null
jq >> /dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not pushed?

@ustiugov ustiugov marked this pull request as draft June 18, 2021 22:39
HermioneKT added a commit that referenced this pull request Jan 31, 2024
@HermioneKT
# This is a combination of 252 commits.
3c6919f 
parent 6674807
author HermioneKT <[email protected]> 1706694164 +0800
committer HermioneKT <[email protected]> 1706694164 +0800

test

# This is the commit message #157:

test

# This is the commit message #159:

test

# This is the commit message #160:

test

# This is the commit message #161:

test

# This is the commit message #162:

test

# This is the commit message #163:

test

# This is the commit message #164:

tesT

# This is the commit message #165:

test

# This is the commit message #166:

test

# This is the commit message #167:

test

# This is the commit message #168:

test

# This is the commit message #169:

test

# This is the commit message #170:

test

# This is the commit message #171:

Test

# This is the commit message #172:

test

# This is the commit message #173:

test

# This is the commit message #174:

test

# This is the commit message #175:

test

# This is the commit message #176:

test

# This is the commit message #177:

test

# This is the commit message #178:

test

# This is the commit message #179:

test

# This is the commit message #180:

test

# This is the commit message #181:

test

# This is the commit message #182:

test

# This is the commit message #183:

test

# This is the commit message #184:

test

# This is the commit message #185:

test

# This is the commit message #186:

test

# This is the commit message #187:

test

# This is the commit message #188:

test

# This is the commit message #189:

test

# This is the commit message #190:

Test

# This is the commit message #191:

Test

# This is the commit message #192:

test

# This is the commit message #193:

Test

# This is the commit message #194:

test

# This is the commit message #195:

test

# This is the commit message #196:

test

# This is the commit message #197:

test

# This is the commit message #198:

test

# This is the commit message #199:

Test

# This is the commit message #200:

test

# This is the commit message #201:

test

# This is the commit message #202:

Test

# This is the commit message #203:

test

# This is the commit message #204:

test

# This is the commit message #205:

test

# This is the commit message #206:

test

# This is the commit message #207:

test

# This is the commit message #208:

test

# This is the commit message #209:

test

# This is the commit message #210:

test

# This is the commit message #211:

Test

# This is the commit message #212:

test

# This is the commit message #213:

Test

# This is the commit message #214:

Test

# This is the commit message #215:

Test

# This is the commit message #216:

test

# This is the commit message #217:

Test

# This is the commit message #218:

test

# This is the commit message #219:

test

# This is the commit message #220:

test

# This is the commit message #221:

test

# This is the commit message #222:

test

# This is the commit message #223:

test

# This is the commit message #224:

test

# This is the commit message #225:

test

# This is the commit message #226:

test

# This is the commit message #227:

test

# This is the commit message #228:

test

# This is the commit message #229:

Test

# This is the commit message #230:

test

# This is the commit message #231:

test

# This is the commit message #232:

test

# This is the commit message #233:

test

# This is the commit message #234:

Test

# This is the commit message #235:

test

# This is the commit message #236:

test

# This is the commit message #237:

test

# This is the commit message #238:

test

# This is the commit message #239:

test

# This is the commit message #240:

test

# This is the commit message #241:

test

# This is the commit message #242:

test

# This is the commit message #243:

test

# This is the commit message #244:

test

# This is the commit message #245:

test

# This is the commit message #246:

test

# This is the commit message #247:

test

# This is the commit message #248:

test

# This is the commit message #249:

test

# This is the commit message #250:

test

# This is the commit message #251:

test

# This is the commit message #252:

test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ustiugov ustiugov ustiugov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@shyamjesal shyamjesal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a script that rebuilds the dependencies' binaries
2 participants
@shyamjesal @ustiugov