threads are always tricky

vgl-hub · Dec 26, 2024 · ddd6f33 · ddd6f33
1 parent a619476
commit ddd6f33
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/include/reads.h b/include/reads.h
@@ -54,7 +54,7 @@ class InReads {
     LenVector<float> readLens;
     uint64_t totA=0, totT=0, totC=0, totG=0, totN=0;
 
-    std::atomic<bool> streamOutput{false};
+    bool streamOutput = false;
     std::thread writer;
     std::condition_variable writerMutexCondition;
 

diff --git a/src/reads.cpp b/src/reads.cpp
@@ -714,9 +714,14 @@ void InReads::closeStream() {
     if (bam)
         closeBam();
 
-    streamOutput = false;
-    if (writer.joinable())
+    if (writer.joinable()) {
+        {
+            std::unique_lock<std::mutex> lck(mtx);
+            streamOutput = false;
+        }
+        writerMutexCondition.notify_one();
         writer.join();
+    }
 }
 
 void InReads::writeToStream() {