Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing import clixml mocks from dbatools koans #464

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Removing import clixml mocks from dbatools koans #464

wants to merge 4 commits into from

Conversation

shaneis
Copy link
Contributor

@shaneis shaneis commented Dec 22, 2021

PR Summary

Removes the dependency on importing XML files for [PSCustomObject]s in the actual files.

Context

Adds mocks for each dbatools koan to the required file themselves.

Changes

Moved the Import-Clixml for [PSCustomObject] code in the files

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steviecoaster steviecoaster Awaiting requested review from steviecoaster steviecoaster is a code owner

@vexx32 vexx32 Awaiting requested review from vexx32 vexx32 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shaneis