-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Pester v5.2.1 #443
Draft
vexx32
wants to merge
9
commits into
main
Choose a base branch
from
413-Pester-v5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pester v5.2.0 added the ability to natively run just the discovery phase of a test suite, so we refactor Measure-Koan to utilize this and save doing a lot of manual work. This also obsoletes the private Measure-KoanTestBlock command that previously supported Measure-Koan. Pester automatically does that calculation on its own before presenting the discovery results. This command has been removed as a result.
In some cases it looks like Pester can fail to publish if there are too many versions of Pester available. Prevent this by checking the version we actually need and publishing just that version when doing a publish to the filesystem. Also set the initially installed version of pester to the correct version based on the current required version specified by PSKoans itself, instead of having to update the environment-setup.yml each time.
vexx32
added
Category-Build 🚀
Modifies the build / deployment system
Category-Module
Pertaining to the module's functionality itself.
labels
May 6, 2021
This issue was fixed in 5.2.1 of Pester
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Category-Build 🚀
Modifies the build / deployment system
Category-Module
Pertaining to the module's functionality itself.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Update to Pester v5 and take advantage of the Run.SkipRun features added to remove some of the awfully hacky discovery-only code we needed in older Pester versions.
Resolves #413
Context
Pester v5.2.0 added options to allow us to natively skip the actual Run phase and just get test metadata back. This makes the necessary changes to use the functionality properly, instead of relying on unsupported and hacky methods of getting that data.
Changes
Checklist