Merge pull request #28 from vespinola/11-add-plurals-to-localization

added plurals
vespinola · Jun 26, 2024 · 9b04390 · 9b04390
2 parents 7d6b701 + d79eb92
commit 9b04390
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 6 deletions.
diff --git a/mobile-courier-app/Presentation/ShipmentDetail/ShipmentDetailView.swift b/mobile-courier-app/Presentation/ShipmentDetail/ShipmentDetailView.swift
@@ -37,7 +37,7 @@ struct ShipmentDetailView: View {
   @ViewBuilder
   private func getHeader() -> some View {
     HStack(alignment: .top) {
-      Text("Shipment \(groupedPackage.formattedId)")
+      Text("Shipment #\(groupedPackage.formattedId)")
         .foregroundStyle(.accent)
         .fontWeight(.bold)
       Spacer()

diff --git a/mobile-courier-app/Utilities/Localizable.xcstrings b/mobile-courier-app/Utilities/Localizable.xcstrings
@@ -6,10 +6,40 @@
     },
     "%lld packages" : {
       "localizations" : {
+        "en" : {
+          "variations" : {
+            "plural" : {
+              "one" : {
+                "stringUnit" : {
+                  "state" : "translated",
+                  "value" : "%lld package"
+                }
+              },
+              "other" : {
+                "stringUnit" : {
+                  "state" : "new",
+                  "value" : "%lld packages"
+                }
+              }
+            }
+          }
+        },
         "es" : {
-          "stringUnit" : {
-            "state" : "translated",
-            "value" : "%lld paquetes"
+          "variations" : {
+            "plural" : {
+              "one" : {
+                "stringUnit" : {
+                  "state" : "translated",
+                  "value" : "%lld paquete"
+                }
+              },
+              "other" : {
+                "stringUnit" : {
+                  "state" : "translated",
+                  "value" : "%lld paquetes"
+                }
+              }
+            }
           }
         }
       }
@@ -242,12 +272,12 @@
         }
       }
     },
-    "Shipment %@" : {
+    "Shipment #%@" : {
       "localizations" : {
         "es" : {
           "stringUnit" : {
             "state" : "translated",
-            "value" : "Embarque %@"
+            "value" : "Embarque #%@"
           }
         }
       }