feat: saving state of features upon reload #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and text-spacing
Deploying with
|
| Latest commit: |
2c2ba55
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://44dbb8f0.astral-accessibility.pages.dev |
| Branch Preview URL: | https://widget-state-save.astral-accessibility.pages.dev |
choyiny
requested changes
Aug 24, 2023
projects/astral-accessibility/src/lib/astral-accessibility.component.ts
Outdated
Show resolved
Hide resolved
projects/astral-accessibility/src/lib/controls/accessability.component.ts
Outdated
Show resolved
Hide resolved
projects/astral-accessibility/src/lib/controls/contrast.component.ts
Outdated
Show resolved
Hide resolved
projects/astral-accessibility/src/lib/controls/screen-mask.component.ts
Outdated
Show resolved
Hide resolved
choyiny
requested changes
Sep 13, 2023
Comment on lines
+101
to
+103
| this.currentState, | ||
| "astralAccessibility_contrastState", | ||
| this.states.length, |
There was a problem hiding this comment.
I feel like first and last argument can be defined only in accessibility.component.ts, and we can make the second argument be defined as a class variable and have the parent read it as well. Hope that makes sense.
Read more on Template Method Design Pattern: https://refactoring.guru/design-patterns/template-method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and text-spacing