fix: allow specifying some flags as config #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API server URL, insecure mode, and CA certs can now be specified via a config file, as well as command line arguments. This is a fix owing to an oversight when support for config files was originally added. As part of this, --api-server flag is no longer marked as mandatory (as the corresponding config could be used instead). Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API server URL, insecure mode, and CA certs can now be specified via a config file, as well as command line arguments. This is a fix owing to an oversight when support for config files was originally added.
As part of this, --api-server flag is no longer marked as mandatory (as the corresponding config could be used instead).