Add CoRIM extension mechanisms #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove deprecated linters from .golangci.yml, ensuring that their replacements are present. Fix any new lint issues resulting from the same. Signed-off-by: Sergei Trofimov <[email protected]>
Replace a single uint8 bitfield used to keep track of op flags with a flags map that allows tristate flags (true, false, and unset). This reflects flags representation in https://www.ietf.org/archive/id/draft-ietf-rats-corim-02.html Signed-off-by: Sergei Trofimov <[email protected]>
setrofim
requested review from
thomas-fossati,
yogeshbdeshpande and
nedmsmith
setrofim
force-pushed
the
feature-extensions
branch
from
5b2ee02
to
98cded0
Compare
|
My apologies, my review is getting staggered. I will try to finish by tomorrow or by end of Friday . |
setrofim
force-pushed
the
feature-extensions
branch
from
be68025
to
34c09f6
Compare
setrofim
force-pushed
the
feature-extensions
branch
from
34c09f6
to
a152ac9
Compare
setrofim
force-pushed
the
feature-extensions
branch
5 times, most recently
from
6894b70
to
23721b5
Compare
setrofim
force-pushed
the
feature-extensions
branch
from
23721b5
to
7e9736e
Compare
setrofim
force-pushed
the
feature-extensions
branch
from
2c6ad82
to
0e9bfc7
Compare
setrofim
force-pushed
the
feature-extensions
branch
from
a7cbf08
to
e8a6d51
Compare
setrofim
force-pushed
the
feature-extensions
branch
2 times, most recently
from
36ef238
to
a60ac55
Compare
Implement struct extension mechanism and add extension points in places specified by https://www.ietf.org/archive/id/draft-ietf-rats-corim-02.html Extensions are implemented via Extensions object that allows registering user-defined structs are extensions. Fields from these user-defined structs are merged into the parent struct that embeds the Extensions object via some custom serialization code (this required updating the cbor dependency to v2.5.0, and go version to 1.19). Extensions also implements Viper*-like accessor methods for convenient access to the extension fields from the parent struct. (* see github.com/spf13/viper) Signed-off-by: Sergei Trofimov <[email protected]>
setrofim
force-pushed
the
feature-extensions
branch
2 times, most recently
from
f7bd658
to
253836f
Compare
yogeshbdeshpande
approved these changes
Nov 10, 2023
setrofim
force-pushed
the
feature-extensions
branch
from
253836f
to
f4b6a7e
Compare
thomas-fossati
approved these changes
Nov 13, 2023
Implement an extensions mechanism for entries identified as "type-choice" in the [CoRIM] spec draft 2. This done by defining a common registration pattern for ITypeChoiceValue interface implementations (the interface is often extended for specific extension points). A Register function is used to associate a factory that produces a type choice instance populated with an appropriate value with a CBOR tag. The factory function must be able to handle nil values, resulting in the zero-value for the associated type; aside from the, the range of valid values the factory can handle is type-specific. A couple of the entries indicates as type choices in the spec (rel and role) are in fact extensible enums, rather than types, so they're implemented somewhat differently. The registration function for them just takes the new value and associated name; there is no need for a factory function. Additionally: - add tagged-int-type implementation for class-id - add EntityName type to represent entity-name type choice (entity-name was previously implemented as a string) - add String() method for comid.Role and corim.Role [CoRIM]: https://www.ietf.org/archive/id/draft-ietf-rats-corim-02.html Signed-off-by: Sergei Trofimov <[email protected]>
setrofim
force-pushed
the
feature-extensions
branch
5 times, most recently
from
733f341
to
83a1a5b
Compare
Add documentation on how to use the newly added extensions mechanisms to implement CoRIM extensions. Signed-off-by: Sergei Trofimov <[email protected]>
setrofim
force-pushed
the
feature-extensions
branch
from
83a1a5b
to
3cfdf38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mechanisms to allow extending
corimimplementation at the map-extension and type-choice extension points defined by the spec.