Switch to v2 and implement crypto keys #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The former name is deprecated in the latest go-cose. Signed-off-by: Sergei Trofimov <[email protected]>
setrofim
force-pushed
the
crypto-keys
branch
3 times, most recently
from
4c71a65
to
f2e5262
Compare
|
@setrofim Thank you for the change, I will review it little later today! |
setrofim
force-pushed
the
crypto-keys
branch
from
f2e5262
to
fb52dbb
Compare
yogeshbdeshpande
approved these changes
Sep 12, 2023
setrofim
force-pushed
the
crypto-keys
branch
from
fb52dbb
to
2814726
Compare
There is already a v1 release published to pkg.dev. This was premature as a number of breaking changes to the API are still planned. The underlying spec is still in development with regular drafts being released. This code is going to change tracking the changes in the spec, as well as likely making non-spec changes to the API as they slowly mature. In order to stay compliant with golang [versioning workflow](https://go.dev/doc/modules/release-workflow), development is witching over to v2, so that v1 can remain stable. (note: the first full v2 release is expected to align with the final publication of the CoRIM spec, and so will not happen for some time. In the mean time, "release candidates" will be published to provided milestone references for dependents) Signed-off-by: Sergei Trofimov <[email protected]>
Implement Crypto Keys as described by section 3.1.4.1.6 of draft-ietf-rats-corim-02: https://www.ietf.org/archive/id/draft-ietf-rats-corim-02.html#name-crypto-keys The replaces the equivalent VerifKey construct in the existing implementation. Crypo Keys are one of pre-defined types, allowing for stronger validation of the underlying value. As part of this change, the dependency on swid library is updated to the most current version, which changes the representation of digests to use ";" instead of ":" as the separator. Signed-off-by: Sergei Trofimov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2development, as, going forward, we're going to be implementing breaking changes from the v1 releasesgo-cosealgorithm name