comid: Add OVMF metadata to the Measurement type #114
Conversation
SEV-SNP launch digest is a function of OVMF metadata, among others. Therefore, this patch adds support to add it as a reference value to Veraison. Signed-off-by: Jagannathan Raman <[email protected]> Reviewed-by: Liam Merwick <[email protected]> Reviewed-by: Ian Chin Wang <[email protected]>
Signed-off-by: Thomas Fossati <[email protected]>
jraman567
force-pushed
the
main-ovmf-changes-v1
branch
from
720fb0e
to
2ebecbb
Compare
|
Hi there, Please review this pull request and let me know if I need to make any changes. I ran make lint; make presubmit. lint didn't report any errors. However, it needs Golang version 1.21 to complete; golangci-lint needs a minimum of 1.21. presubmit reported a few errors. However, they are existing errors. Thank you, @thomas-fossati for the CI patch. Thank you! |
|
Hi @yogeshbdeshpande @thomas-fossati @setrofim , I just sent a pull request to add OVMF metadata to CoRIM reference values. Please let me know if it looks good. Thank you, @thomas-fossati , for fixing the CI issue. -- |
| UEID *eat.UEID `cbor:"9,keyasint,omitempty" json:"ueid,omitempty"` | ||
| UUID *UUID `cbor:"10,keyasint,omitempty" json:"uuid,omitempty"` | ||
| IntegrityRegisters *IntegrityRegisters `cbor:"14,keyasint,omitempty" json:"integrity-registers,omitempty"` | ||
| OvmfMetadata *ovmf.MetadataWrapper `cbor:"15,keyasint,omitempty" json:"ovmf-metadata,omitempty"` |
There was a problem hiding this comment.
This needs to be done as extension work, not natively inside CoRIM.
There was a problem hiding this comment.
Hi @jraman567, thanks very much for your contribution.
From the CoRIM perspective, OvmfMetadata is a profile-specific extension. Since it's not part of the base spec, it should be handled using veraison/corim's extensions framework rather than adding it directly into struct Mval.
Of course, we can work with you to make the needed changes.
|
Thanks for the feedback, @thomas-fossati ! I'll get back to you with that change. |
SEV-SNP launch digest is a function of OVMF metadata, among others. Therefore, this patch adds support to add it as a reference value to Veraison.
We need this reference value to compute the SEV-SNP launch digest on-demand.