Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Integrity registers #107

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add Integrity registers #107

merged 1 commit into from
Feb 20, 2024

Conversation

yogeshbdeshpande
Copy link
Contributor

@yogeshbdeshpande yogeshbdeshpande commented Jan 30, 2024 •
edited
Loading

This PR implements the recently added Integrity Registers (https://ietf-rats-wg.github.io/draft-ietf-rats-corim/draft-ietf-rats-corim.html#name-integrity-registers) to the CoRIM schema.

Fixes #108

@yogeshbdeshpande yogeshbdeshpande changed the title Integ registers Add Integrity registers Feb 2, 2024
@yogeshbdeshpande yogeshbdeshpande self-assigned this Feb 2, 2024
@yogeshbdeshpande yogeshbdeshpande marked this pull request as ready for review February 2, 2024 19:00
thomas-fossati
thomas-fossati reviewed Feb 3, 2024
View reviewed changes
comid/integregisters.go Outdated Show resolved Hide resolved
comid/integregisters.go Outdated Show resolved Hide resolved
comid/integregisters_test.go Outdated Show resolved Hide resolved
comid/integregisters.go Outdated Show resolved Hide resolved
comid/integregisters_test.go Outdated Show resolved Hide resolved
comid/integregisters_test.go Outdated Show resolved Hide resolved
comid/integregisters_test.go Outdated Show resolved Hide resolved
comid/integregisters.go Outdated Show resolved Hide resolved
comid/integregisters.go Outdated Show resolved Hide resolved
@yogeshbdeshpande
Copy link
Contributor Author

@thomas-fossati Thank you so much for the comments! I shall review the same and discuss if required.

@thomas-fossati
Copy link
Contributor

@thomas-fossati Thank you so much for the comments! I shall review the same and discuss if required.

👍

One more thing: could you please squash the two commits into one? There seems to be no reason for their separate existence.

@yogeshbdeshpande
Copy link
Contributor Author

@thomas-fossati Thank you so much for the comments! I shall review the same and discuss if required.

👍

One more thing: could you please squash the two commits into one? There seems to be no reason for their separate existence.

Indeed!

@yogeshbdeshpande
Copy link
Contributor Author

@thomas-fossati Thank you so much for the comments! I shall review the same and discuss if required.

👍
One more thing: could you please squash the two commits into one? There seems to be no reason for their separate existence.

Indeed!

I have done the squash and will incorporate the comments, as discussed!

setrofim
setrofim reviewed Feb 5, 2024
View reviewed changes
comid/integregisters.go Outdated Show resolved Hide resolved
thomas-fossati
thomas-fossati reviewed Feb 6, 2024
View reviewed changes
comid/integrityregisters.go Outdated Show resolved Hide resolved
comid/integrityregisters.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
thomas-fossati
thomas-fossati reviewed Feb 20, 2024
View reviewed changes
Copy link
Contributor

@thomas-fossati thomas-fossati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of spurious blocks to remove

the rest looks good, thanks!

comid/integrityregisters_test.go Show resolved Hide resolved
comid/integrityregisters_test.go Outdated Show resolved Hide resolved
@yogeshbdeshpande
Add Integrity Registers
eb0a3b5 
Fixes #108

Signed-off-by: Yogesh Deshpande <[email protected]>
@yogeshbdeshpande yogeshbdeshpande merged commit 25d970d into main Feb 20, 2024
9 checks passed
@yogeshbdeshpande yogeshbdeshpande deleted the integ-registers branch February 20, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-fossati thomas-fossati thomas-fossati approved these changes

@setrofim setrofim Awaiting requested review from setrofim

Assignees

@yogeshbdeshpande yogeshbdeshpande

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Integrity Register changes
3 participants
@yogeshbdeshpande @thomas-fossati @setrofim