Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add verification token strategy #3294

Merged

Conversation

twlite
Copy link
Contributor

@twlite twlite commented Dec 24, 2024

Description

Closes #3293

Breaking changes

No, the changes should not break existing codebase. This is because it is only being used internally and internal conflicts have been resolved properly.

Screenshots

N/A

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 26, 2024 5:06am

Copy link
Member

@michaelbromley michaelbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is basically a perfect implementation of the feature. Bravo!

@michaelbromley michaelbromley merged commit 9375ba2 into vendure-ecommerce:minor Dec 30, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
@twlite twlite deleted the verification-token-strategy branch December 30, 2024 14:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants