Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payments-plugin): use some instead of find #3292

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

twlite
Copy link
Contributor

@twlite twlite commented Dec 24, 2024

Description

This pull request includes a small change to the currencyHasFractionPart function in the stripe-utils.ts file. The change improves the readability of the code by replacing the find method with the some method to check for the presence of a fraction part in the currency formatting.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Dec 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 24, 2024 0:02am

@twlite twlite changed the title fix(stripe-utils): use some instead of find fix(payments-plugin): use some instead of find Dec 24, 2024
@michaelbromley michaelbromley merged commit ba3c875 into vendure-ecommerce:master Dec 30, 2024
31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2024
@twlite twlite deleted the patch-1 branch December 30, 2024 16:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants