Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProductVariantPrice custom fields ui inputs #3263

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add ProductVariantPrice custom fields ui inputs #3263

wants to merge 2 commits into from

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Dec 6, 2024 •
edited
Loading

Description

Breaking changes

The admin-api schema needs to be updated. The Typescript should not break though, so it should be safe to update.

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@vercel Vercel
Copy link

vercel bot commented Dec 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 6, 2024 4:53pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

Kevin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@Draykee Draykee changed the title (WIP) Added ProductVariantPrice custom fields ui inputs (WIP) Added ProductVariantPrice custom fields ui inputs (#3020) Dec 6, 2024
Draykee
Draykee commented Dec 6, 2024
View reviewed changes
.../src/lib/catalog/src/components/product-variant-detail/product-variant-detail.component.html Outdated
[customFieldsFormGroup]="price.get(['customFields'])"
[readonly]="!(updatePermissions | hasPermission)"
/>
{{ price.get(['customFields'])?.value | json}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only for debugging - remove later!

@Draykee
Copy link
Contributor Author

Draykee commented Dec 6, 2024

image
TODO: Improve the card and blend it into the current design

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.4% Duplication on New Code

See analysis details on SonarQube Cloud

@Draykee Draykee changed the title (WIP) Added ProductVariantPrice custom fields ui inputs (#3020) Add ProductVariantPrice custom fields ui inputs Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose admin-ui for custom fields on ProductVariantPrice.
1 participant
@Draykee