Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(payments-plugin): Optionally, do not throw if Stripe payment intent doesn't have Vendure metadata #3250

Conversation

jezzzm
Copy link
Contributor

@jezzzm jezzzm commented Dec 1, 2024

Description

#3249 - gracefully handle non-vendure payment intents from Stripe

Included an option for the consumer as this could be a breaking change otherwise, though it seems extremely unlikely.

Breaking changes

Does this PR include any breaking changes we should be aware of?

Screenshots

You can add screenshots here if applicable.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Dec 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 1, 2024 8:11am

Copy link
Contributor

github-actions bot commented Dec 1, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link

sonarqubecloud bot commented Dec 1, 2024

@jezzzm jezzzm changed the title feat: Optionally, do not throw if Stripe payment intent doesn't have Vendure metadata feat(payments-plugin): Optionally, do not throw if Stripe payment intent doesn't have Vendure metadata Dec 1, 2024
@jezzzm
Copy link
Contributor Author

jezzzm commented Dec 3, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Dec 3, 2024
@michaelbromley michaelbromley changed the base branch from master to minor December 3, 2024 07:54
@michaelbromley michaelbromley merged commit ec934dd into vendure-ecommerce:minor Dec 3, 2024
29 of 30 checks passed
@michaelbromley
Copy link
Member

Thank you! This will be in v3.1

@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants