Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wrong join statement for variant on ProductVariantPrice #3231

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

Draykee
Copy link
Contributor

@Draykee Draykee commented Nov 25, 2024

Description

Fixed wrong join name for variant on ProductVariantPrice

Breaking changes

Nope, most likely most people never even used this function.

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 25, 2024 4:49pm

Copy link
Contributor

github-actions bot commented Nov 25, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Draykee
Copy link
Contributor Author

Draykee commented Nov 25, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Nov 25, 2024
@michaelbromley michaelbromley merged commit 7798ddc into vendure-ecommerce:master Nov 29, 2024
30 checks passed
@michaelbromley
Copy link
Member

Thanks! Kinda crazy this was just totally wrong and never discovered before...

@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants