feat(core) Add CreateUser method to ExternalAuthenticationService Helper #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nly from external Auth provider
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
|
recheck |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added createUser method to external authentication helper to support the case where user is authenticated via external provider without email. There is a case (ie mobile app only store) where we only want authenticated users to see products and and be able to add to carts. This is also useful for anti-scraping.
I also returned savedUser from all methods for consistency and added type for missing method.
Breaking changes
Nope
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
I added code description which will auto update readme
👍 Most of the time:
I have read the CLA Document and I hereby sign the CLA
AHMET TOK
ARRRRNY