perf(core): Improve hydrator performance for customFields #2961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a workaround that led to refetching relations in customFields. Prevent refetching of customFields during hydration
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michaelbromley
merged commit f40761d
into
vendure-ecommerce:master
13 of 14 checks passed
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove a workaround that led to refetching relations in customFields. Prevent refetching of customFields during hydration
Fixes #2696
Description
See #2696. There was some sort of workaround that disabled the check which is in place to prevent reloading the same data over and over.
entity["customFields.xyz"]will never be set because the data would be inentity["customFields"]["xyz"].I'm still wondering if there is some edge case that made this workaround necessary but we are running this patch in production for quite some time now and we are using a lot of
customFields.Breaking changes
None I would be aware of. This might have been a workaround for a bug in typeorm maybe.
Checklist
📌 Always:
👍 Most of the time: