feat(admin-ui): Add location id and description to custom routes #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rein1410
changed the title
Draykee
reviewed
Jul 9, 2024
| @@ -53,5 +64,14 @@ export class RouteComponent { | |||
| this.title$ = combineLatest([inject(ROUTE_COMPONENT_OPTIONS).title$, breadcrumbLabel$]).pipe( | |||
| map(([title, breadcrumbLabel]) => title ?? breadcrumbLabel), | |||
| ); | |||
|
|
|||
| this.locationId = this.route.snapshot.data.locationId; | |||
There was a problem hiding this comment.
Is there a default locationId or can this be undefined?
There was a problem hiding this comment.
both locationId and description can be undefined
|
Are you updating the docs as well? :)
Maybe add a hint here as well, since it's relevant for the tabs right? |
michaelbromley
merged commit 26b4ea5
into
vendure-ecommerce:minor
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
descriptionandlocationIdtoregisterRouteComponentandregisterReactRouteComponentso that users can define custom description and page tabs to their custom routes vis theregisterPageTabAPI.Breaking changes
Does this PR include any breaking changes we should be aware of?
no
Screenshots
Checklist
📌 Always:
👍 Most of the time: