Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-server): Update postgres credentials in docker compose #2811

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

dlhck
Copy link
Collaborator

@dlhck dlhck commented Apr 25, 2024

Description

This PR changes the Postgres database name and the credentials in the docker compose to be the same as in the dev-config.ts

Breaking changes

none

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

@dlhck dlhck changed the base branch from master to minor April 25, 2024 11:06
@dlhck dlhck requested a review from michaelbromley April 25, 2024 11:06
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for effervescent-donut-4977b2 failed.

Name Link
🔨 Latest commit 5658b96
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/662a393808a8b800080480d9

@@ -62,9 +62,9 @@ services:
image: postgres:12.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it better to go to latest 16 version for testing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good point but can be a separate PR 👍

@michaelbromley michaelbromley merged commit 2f36a7c into minor Apr 25, 2024
12 of 16 checks passed
@dlhck dlhck deleted the fix/default-postgres-db branch April 29, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants