Update channel-detail.component.html defaultShippingZoneId is Required #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default Shipping Zone Id is required field. Alert dialog should have danger instead of warning. Also translations need to be changed. Instead of "this may cause errors" it should be "which will cause errors' like the tax alert
✅ Deploy Preview for effervescent-donut-4977b2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
michaelbromley
merged commit 7bae5d7
into
vendure-ecommerce:master
17 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default Shipping Zone Id is required field. Alert dialog should be danger instead of warning.
Also translations need to be changed. Instead of "this may cause errors" it should be "which will cause errors' like the tax alert
Breaking changes
NO
Screenshots
Checklist
📌 Always:
👍 Most of the time: