fix(core): Add channels to asset entities on admin api #2717
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I found that the channel-aware asset entities obviously have a
channels
field but its actually not exposed in the admin api. It got added in #700 but cant be queried.Please note: I purposefully have not included re-generated types to make this PR as concise and review-able as possible.
For finishing this PR it should probably include this newly exposed field in the e2e-tests! Note that you'll need to look into the following when running:
You'll see a
eventhough the mutation will go through and work!
Please someone feel free to take over this PR, I just wanted to create this as the starting point for fixing #2478 but theres more to do there for example maybe a
removeAssetsFromChannel
mutation and ui which I dont want to do because of Angular & RxJs 😄Breaking changes
Should be none AFAIK
Screenshots
You can add screenshots here if applicable.
Checklist
📌 Always:
👍 Most of the time: