Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add read_only_instance flag #164

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix: add read_only_instance flag #164

merged 2 commits into from
Sep 18, 2024

Conversation

friedger
Copy link
Contributor

This PR

  • improves the confusion about the account registration in Documentation? #108
  • adds an env flag VITE_IS_READONLY_INSTANCE
  • shows Account registration is not supported by the demo Vendure instance only for readonly instances

@gioboa
Copy link
Collaborator

gioboa commented Sep 18, 2024

Thanks @friedger can you resolve the conflicts pls?

@friedger
Copy link
Contributor Author

Done @gioboa

gioboa
gioboa approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great @friedger

@gioboa gioboa merged commit db120ab into vendure-ecommerce:main Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioboa gioboa gioboa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@friedger @gioboa