Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix angular dependencies conflicts #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix angular dependencies conflicts #88

wants to merge 1 commit into from

Conversation

mkashifaslam
Copy link

No description provided.

@michaelbromley
Copy link
Member

Hi!
Thanks for the contribution! Unfortunately another change I just merged means this has some conflicts to resolve. Probably the needs to have the other changed merged and then run yarn again to update the lockfile.

By the way, what conflicts is this resolving?

@kashifaslamveeve
Copy link

Hi!
Thanks for the contribution! Unfortunately another change I just merged means this has some conflicts to resolve. Probably the needs to have the other changed merged and then run yarn again to update the lockfile.

By the way, what conflicts is this resolving?

I was facing angular build issues when ran it locally so I resolved those issues and tested it and everything is working fine now, so t I thought it's better to merge these changes in main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mkashifaslam @michaelbromley @kashifaslamveeve @mohamedkashifaslam