LpSugar: added Lp.root. #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrovalido
approved these changes
Oct 30, 2024
stas
force-pushed
the
root_pool
branch
6 times, most recently
from
ec382c7 to
b120fdf
Compare
stas
commented
Nov 4, 2024
| ) | ||
| ) | ||
|
|
||
|
|
There was a problem hiding this comment.
TODO: replace all below with
https://github.com/pcaversaccio/snekmate/blob/main/src/snekmate/utils/create2_address.vy#L49-L76
Consider:
from snekmate.utils import create2_address
@internal
@view
def _root_lp_address(
_factory: address,
_token0: address,
_token1: address,
_type: int24
) -> address:
...
create2_address._compute_address(salt, init_hash, _factory)
pcaversaccio
reviewed
Nov 4, 2024
|
|
||
| salt: bytes32 = empty(bytes32) | ||
|
|
||
| if _type < 1: |
There was a problem hiding this comment.
You could rewrite the if-else block like this:
common: Bytes[72] = concat(convert(chain.id, bytes32), convert(_token0, bytes20), convert(_token1, bytes20))
salt = keccak256(concat(common, 0x00)) if (_type == 0) else keccak256(concat(common, convert(_type, bytes3)))Probably the recommended approach consumes slightly more gas, but is definitely more readable imo.
stas
force-pushed
the
root_pool
branch
2 times, most recently
from
08e29c2 to
4989852
Compare
stas
force-pushed
the
root_pool
branch
2 times, most recently
from
84ae874 to
96fa367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Lp.rootrepresenting root (placeholder) pool address, for (non-canonical) leaf chain pools.