Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove floor fillet for efloor mode [1] #39

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danielsan80
Copy link

@danielsan80 danielsan80 commented Nov 7, 2024

Hi Jamie.

This is my first attempt to contributing to the project to get more familiar with it.

Maybe it's just my personal taste, so feel free to reject this PR.

In efloor mode, you dig the standard floor which has a spherical fillet, but I'm not sure a filleted floor inner edge is functional in this case.
In my opinion, a sharpen inner edge might be more effective.

To try the change, in gridfinity_basic_cup.scad, set:

depth = 2;
fingerslide = false;
efficient_floor = true;

Thanks for your job.

@danielsan80 danielsan80 changed the title cleanup floor difference overhangs remove floor fillet for efloor mode Nov 7, 2024
@danielsan80 danielsan80 changed the title remove floor fillet for efloor mode Remove floor fillet for efloor mode [1] Nov 7, 2024
@ostat
Copy link

ostat commented Nov 7, 2024

I don't think @vector76 is still working on this project.

Gridfinity extended which is built on this library is still active.
Happy for you to submit your ideas over there if you are interested https://github.com/ostat/gridfinity_extended_openscad

@danielsan80
Copy link
Author

Ah ok.
Thankyou @ostat.

I didn't find your repo before.

I'll switch to your project very soon.

@danielsan80
Copy link
Author

UPDATE: This issue was solved by @ostat in his project https://github.com/ostat/gridfinity_extended_openscad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants