Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
vberthiaume committed Oct 29, 2024
1 parent c454643 commit 8b51561
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 10 deletions.
4 changes: 0 additions & 4 deletions benchmarks/Benchmarks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,13 @@ TEST_CASE ("Boot performance")
BENCHMARK_ADVANCED ("Processor constructor")
(Catch::Benchmark::Chronometer meter)
{
//TODO: might need to uncomment all 3 of these
// auto gui = juce::ScopedJuceInitialiser_GUI {};
std::vector<Catch::Benchmark::storage_for<ProPhatProcessor>> storage (size_t (meter.runs()));
meter.measure ([&] (int i) { storage[(size_t) i].construct(); });
};

BENCHMARK_ADVANCED ("Processor destructor")
(Catch::Benchmark::Chronometer meter)
{
// auto gui = juce::ScopedJuceInitialiser_GUI {};
std::vector<Catch::Benchmark::destructable_object<ProPhatProcessor>> storage (size_t (meter.runs()));
for (auto& s : storage)
s.construct();
Expand All @@ -26,7 +23,6 @@ TEST_CASE ("Boot performance")
BENCHMARK_ADVANCED ("Editor open and close")
(Catch::Benchmark::Chronometer meter)
{
// auto gui = juce::ScopedJuceInitialiser_GUI {};
ProPhatProcessor plugin;

// due to complex construction logic of the editor, let's measure open/close together
Expand Down
5 changes: 0 additions & 5 deletions tests/PluginBasics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,6 @@ TEST_CASE ("Plugin instance", "[instance]")
{
ProPhatProcessor testPlugin;

// This lets us use JUCE's MessageManager without leaking.
// PluginProcessor might need this if you use the APVTS for example.
// You'll also need it for tests that rely on juce::Graphics, juce::Timer, etc.
// auto gui = juce::ScopedJuceInitialiser_GUI {};

SECTION ("name")
{
CHECK_THAT (testPlugin.getName().toStdString(),
Expand Down
1 change: 0 additions & 1 deletion tests/helpers/test_helpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
[[maybe_unused]] void runWithinPluginEditor (const std::function<void (ProPhatProcessor& plugin)>& testCode)
{
ProPhatProcessor plugin;
// auto gui = juce::ScopedJuceInitialiser_GUI {};
auto editor = plugin.createEditorIfNeeded();

testCode (plugin);
Expand Down

0 comments on commit 8b51561

Please sign in to comment.