Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - Sandpack configuration #1386

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Docs - Sandpack configuration #1386

merged 2 commits into from
Dec 6, 2024

Conversation

piotrpospiech
Copy link
Collaborator

@piotrpospiech piotrpospiech commented Nov 29, 2024

  • configured basic Sandpack setup
  • created first example - "basic usage". It is more a template for us to create other examples
  • removed password from "getting started/basic usage" as input wasn't type of password and I didn't want to complicate this example with passing custom props
  • added .vscode/settings.json to change default formatter from prettier to mdx. Prettier breaks formatting in template literals in mdx files
  • removed mdx files from prettier configs

@piotrpospiech piotrpospiech added this to the v4.0 milestone Nov 29, 2024
@github-actions github-actions bot added the Area: Docs Affects the documentation or reproductions seed label Nov 29, 2024
@piotrpospiech piotrpospiech mentioned this pull request Nov 29, 2024
11 tasks
@github-actions github-actions bot added the Area: Infra Affects the repository itself (e.g., CI, dependencies) label Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.53%. Comparing base (f751fcb) to head (e1a97e1).
Report is 1 commits behind head on docs.

Additional details and impacted files
@@           Coverage Diff           @@
##             docs    #1386   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files         175      175           
  Lines        2867     2867           
  Branches      773      773           
=======================================
  Hits         2739     2739           
  Misses         59       59           
  Partials       69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piotrpospiech piotrpospiech self-assigned this Nov 29, 2024
@piotrpospiech piotrpospiech merged commit ef088ef into docs Dec 6, 2024
6 checks passed
@piotrpospiech piotrpospiech deleted the sandpack-examples branch December 6, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects the documentation or reproductions seed Area: Infra Affects the repository itself (e.g., CI, dependencies)
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants