-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update typescript
#1369
Merged
Merged
Update typescript
#1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrpospiech
requested review from
wadamek65 and
kestarumper
as code owners
September 13, 2024 15:00
github-actions
bot
added
Area: Infra
Affects the repository itself (e.g., CI, dependencies)
Area: Core
Affects the uniforms package
Area: Theme
Affects some of the theme packages
Area: Bridge
Affects some of the bridge packages
Theme: AntD
Affects the uniforms-antd package
Theme: Bootstrap 4
Affects the uniforms-bootstrap4 package
Theme: Bootstrap 5
Affects the uniforms-bootstrap5 package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
labels
Sep 13, 2024
github-actions
bot
added
Theme: Unstyled
Affects the uniforms-unstyled package
Bridge: JSON Schema
Affects the uniforms-bridge-json-schema package
Bridge: SimpleSchema (v2)
Affects the uniforms-bridge-simple-schema-2 package
Bridge: Zod
Affects the uniforms-bridge-zod package
labels
Sep 13, 2024
kestarumper
approved these changes
Sep 13, 2024
zaxovaiko
approved these changes
Sep 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1369 +/- ##
==========================================
+ Coverage 96.17% 96.34% +0.16%
==========================================
Files 175 175
Lines 2904 2869 -35
Branches 778 775 -3
==========================================
- Hits 2793 2764 -29
Misses 59 59
+ Partials 52 46 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Bridge
Affects some of the bridge packages
Area: Core
Affects the uniforms package
Area: Infra
Affects the repository itself (e.g., CI, dependencies)
Area: Theme
Affects some of the theme packages
Bridge: JSON Schema
Affects the uniforms-bridge-json-schema package
Bridge: SimpleSchema (v2)
Affects the uniforms-bridge-simple-schema-2 package
Bridge: Zod
Affects the uniforms-bridge-zod package
Theme: AntD
Affects the uniforms-antd package
Theme: Bootstrap 4
Affects the uniforms-bootstrap4 package
Theme: Bootstrap 5
Affects the uniforms-bootstrap5 package
Theme: MUI
Affects the uniforms-mui package
Theme: Semantic UI
Affects the uniforms-semantic package
Theme: Unstyled
Affects the uniforms-unstyled package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I wanted to update typescript package in each package.json file from v4.4.4 to v5.5.4. Newer version of typescript is required to create extensible tsconfig structure. In current version, extends option in the tsconfig accepts only string as argument, but array is needed.
To update typescript in the root directory, it was also necessary to update the following packages:
eslint-config-vazco
jest (newer version required also to install jest-environment-jsdom)
ts-jest
Most of the changes are lint/type fixes caused by updated eslint-config-vazco and typescript packages.
I updated JSONSchemaBridge › #getProps › works with anyOf for a non-object computed property (properties not defined) test as properties is not part of tested object. Tested object didn't change in comparison to master branch.
I deprecate also Node v14 in CI workflow and added Node v22.