Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridge constructor changes to v4 migration guide. #1362

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Monteth
Copy link
Member

@Monteth Monteth commented Aug 9, 2024

This PR updates the migration guide for uniforms from v3 to v4 to include information on the changes to constructors in all bridges.
This change addresses issue #1360.

@github-actions github-actions bot added the Area: Docs Affects the documentation or reproductions seed label Aug 9, 2024
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.90%. Comparing base (884581a) to head (062d5f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1362   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files         175      175           
  Lines        2902     2902           
  Branches      778      778           
=======================================
  Hits         2754     2754           
  Misses         59       59           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Monteth Monteth self-assigned this Aug 9, 2024
@kestarumper kestarumper added this to the v4.0 milestone Aug 23, 2024
@kestarumper kestarumper linked an issue Aug 23, 2024 that may be closed by this pull request
@kestarumper kestarumper merged commit 0072468 into master Aug 23, 2024
8 checks passed
@kestarumper kestarumper deleted the update-v4-migration-guide-bridge-constructor branch August 23, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Docs Affects the documentation or reproductions seed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Undocumented JSONSchemaBridge breaking change in v4
3 participants