Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrated Numfield AntD tests to @testing-library/react #1348

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Migrated Numfield AntD tests to @testing-library/react #1348

merged 2 commits into from
Jun 21, 2024

Conversation

kestarumper
Copy link
Member

@kestarumper kestarumper commented Jun 6, 2024 •
edited
Loading

Closes #1344.

Changes

  • NumField (AntD) will now have correct type="number" (<input type="number" />). Fixes issues where value would be a string instead of number
  • Migrated remaining NumField enzyme tests

@kestarumper kestarumper added this to the v4.0 milestone Jun 6, 2024
@kestarumper kestarumper self-assigned this Jun 6, 2024
@kestarumper kestarumper requested a review from wadamek65 as a code owner June 6, 2024 09:13
@github-actions github-actions bot added Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package labels Jun 6, 2024
@kestarumper kestarumper requested a review from a team June 6, 2024 09:16
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.18%. Comparing base (1e53adc) to head (4c8a282).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1348   +/-   ##
=======================================
  Coverage   94.18%   94.18%           
=======================================
  Files         226      226           
  Lines        3664     3664           
  Branches      989      989           
=======================================
  Hits         3451     3451           
  Misses         81       81           
  Partials      132      132

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kestarumper kestarumper merged commit e1c4707 into master Jun 21, 2024
7 checks passed
@kestarumper kestarumper deleted the migrate-numfield-antd branch June 21, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErnestTeluk ErnestTeluk ErnestTeluk approved these changes

@piotrpospiech piotrpospiech piotrpospiech approved these changes

@zaxovaiko zaxovaiko zaxovaiko approved these changes

@Monteth Monteth Monteth approved these changes

@wadamek65 wadamek65 Awaiting requested review from wadamek65

Assignees

@kestarumper kestarumper

Labels
Area: Core Affects the uniforms package Area: Theme Affects some of the theme packages Theme: AntD Affects the uniforms-antd package Theme: Bootstrap 4 Affects the uniforms-bootstrap4 package Theme: Bootstrap 5 Affects the uniforms-bootstrap5 package Theme: MUI Affects the uniforms-mui package Theme: Semantic UI Affects the uniforms-semantic package Theme: Unstyled Affects the uniforms-unstyled package
Projects
Open Source
Archived in project
Milestone
v4.0
Development

Successfully merging this pull request may close these issues.

Migrate NumField AntD tests to @testing-library/react
5 participants
@kestarumper @Monteth @zaxovaiko @piotrpospiech @ErnestTeluk